Add Japanese translations for Faker::Sports::Football.
#2903
Conversation
lib/locales/ja/football.yml
Outdated
| ja: | ||
| faker: | ||
| football: | ||
| teams: ["レアル・マドリード", "FCバルセロナ", "バレンシアCF", "アトレティコ・マドリード", "マンチェスター・ユナイテッド", "チェルシー", "リヴァプール", "アーセナル", "トッテナム・ホットスパー", "ACミラン", "インテル・ミラノ", "ASローマ", "ユヴェントス", "バイエルン・ミュンヘン", "ボルシア・ドルトムント", "シャルケ04", "ベンフィカ", "ガラタサライ", "PSVアイントホーフェン", "LAギャラクシー", "パリ・サンジェルマン"] |
There was a problem hiding this comment.
almost forgot: do you mind converting these into dash syntax? We have instructions here: https://github.com/faker-ruby/faker/blob/main/CONTRIBUTING.md#yaml-files
You can just run this script: bundle exec rake reformat_yaml['path-to-your-file']
There was a problem hiding this comment.
I've made the correction, squashed the commits, and force-pushed. Please review. Thank you!
|
hi @yamat47, could you reformat lib/locales/ja/football.yml so I can merge this? Thanks! |
yamat47
force-pushed
the
add-ja-locales-for-sport-football
branch
from
65587e9
to
7cbc2c5
Compare
yamat47
force-pushed
the
add-ja-locales-for-sport-football
branch
2 times, most recently
from
644a6fd
to
81ae746
Compare
|
@thdaraujo Thank you for the review. I've added automated tests that pass locally but are failing on CI, and I'm looking into why. I used the same style as the rest of the project for RuboCop and am unclear why it's failing. Any specifics you could provide would be helpful. Please let me know if you have any advice on how to proceed. Thank you! |
test/test_ja_locale.rb
Outdated
| def test_ja_football_methods | ||
| # The translation of "team" includes alphabets, so we cannot use assert_not_english for assertion. | ||
| # Example: "FCバルセロナ" (FC Barcelona) | ||
| assert Faker::Sports::Football.team.is_a? String |
There was a problem hiding this comment.
To fix the Rubocop warning:
| assert Faker::Sports::Football.team.is_a? String | |
| assert_kind_of String, Faker::Sports::Football.team |
There was a problem hiding this comment.
@thdaraujo Sorry for the delay in responding.
I have made the necessary corrections and force-pushed the changes. Could you please review them at your earliest convenience?
Thank you!
yamat47
force-pushed
the
add-ja-locales-for-sport-football
branch
from
81ae746
to
79ce64c
Compare
thdaraujo
force-pushed
the
add-ja-locales-for-sport-football
branch
from
79ce64c
to
9e3f456
Compare
Motivation / Background
This Pull Request is created to add new locale data for Japanese football teams, players, coaches, competition names, and positions to this library.
Additional information
This change is based on existing English data, translated by contributors who are native Japanese speakers.
To ensure the accuracy and quality of the translation, it has been reviewed by multiple native speakers knowledgeable in soccer.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator or locale: