Performance: Sample arrays instead of performing shuffle and slice #2940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because shuffling an array then slicing the required amount of array items is less efficient than sampling the array. The sample algorithm picks random items and is more efficient than reordering the entire array.
Additional Information
This PR simply takes each instance of shuffle and slice across the library:
and replaces it with sample:
The internal
Faker.sample
method has been used to replace theshuffle
method in order to still provide deterministic random values.Performance Benchmark
You can see from the benchmark below that after replacing "shuffle and slice" with "sample" the methods are up to 17.7% faster:
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]