Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add League of Legends #878

Merged
merged 8 commits into from
Apr 8, 2017
Merged

Add League of Legends #878

merged 8 commits into from
Apr 8, 2017

Commits on Apr 7, 2017

  1. Add markdown files 

    Add link to League of Legends markdown file with over view of what I
want this PR to accomplish.
    @Dpalazzari
    Dpalazzari committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    92f80f2 View commit details
    Browse the repository at this point in the history

  2. Add tests 

    - Adds test for every LeagueOfLegends method
- Quick edit to markdown file
    @Dpalazzari
    Dpalazzari committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    2ace62a View commit details
    Browse the repository at this point in the history

  3. Add champions 

    - Adds all 136 champions to en.yml file. Includes all 134 active
characters, as well as the two up and coming champions Xayah and Rakan.
    @Dpalazzari
    Dpalazzari committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    779f7b8 View commit details
    Browse the repository at this point in the history

  4. Add content 

    - Adds Class league of legends within Faker module.
- Adds the rest of the content required for the add-on
- All tests pass
    @Dpalazzari
    Dpalazzari committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    44ef8fa View commit details
    Browse the repository at this point in the history

  5. Remove rage component 

    was fun to build, but also kind of silly and stupid.
    @Dpalazzari
    Dpalazzari committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    06aa4d9 View commit details
    Browse the repository at this point in the history

  6. Remove rage form en.yml file

    @Dpalazzari
    Dpalazzari committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    1dd1439 View commit details
    Browse the repository at this point in the history

  7. Remove empty string

    @Dpalazzari
    Dpalazzari committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    4dd4cf7 View commit details
    Browse the repository at this point in the history

  8. Refactor method names

    @Dpalazzari
    Dpalazzari committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    92cb068 View commit details
    Browse the repository at this point in the history