Add Address.mailing_address method. Add tests for Faker::Address. Fix… #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bg with zip_code(state_abbreviation), nullifying need for one test in test_faker_zip_code.rb
|
I merged this without the mailing_address method because it was too similar to the already-existing methods. |
landongrindheim
pushed a commit
to landongrindheim/faker
that referenced
this pull request
Oct 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #841
Add tests for Faker::Address. Fix bug with zip_code(state_abbreviation), nullifying need for one test in test_faker_zip_code.rb
Previously,
en.ymldid not contain a list of postcodes per state, so a call toFaker::Address.zip_code "TX"would fail, unless theFaker::Config.localehad been set to :"en-US". Rather than changing config in the function call, I added postcodes per state intoen.yml. This change nullified the need for the last test intest_faker_zip_code.rb