fix: parse the path for package manually when module is __main__
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badayvedat
previously approved these changes
Jan 4, 2024
|
This is definitely over my head! What is this actually fixing/solving? |
chamini2
reviewed
Jan 12, 2024
| @@ -55,6 +56,16 @@ def add_serialization_listeners_for(obj): | |||
| return None | |||
|
|
|||
| _MODULES.add(module_name) | |||
| if module_name == "__main__": | |||
There was a problem hiding this comment.
can you add an explainer for this. I think it's just including all the parent packages of the file called, right?
Does this help for local imports?
turbo1912
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.