Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fal): automatically lower max/min_concurrency for everyone other than falbot #305

Closed
wants to merge 1 commit into from

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Sep 11, 2024

No description provided.

Copy link
Member

@chamini2 chamini2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are actually about to give other users permissions to use bigger values than this, we cannot change this at client level

@efiop
Copy link
Contributor Author

efiop commented Sep 11, 2024

@chamini2 This is a convenience thing that was requested before. No way to show warnings from the backend to the SDK user, so the only other option than this pr would be to do that (just silently limit the values) in the backend. I'm alright with that approach, happy to switch to that if you are in favor of that too.

@isidentical
Copy link
Collaborator

can we not run checks for these when people are doing fal run?

@isidentical
Copy link
Collaborator

I don't expect anyone to deploy anything from non-fal bot accounts. fal run covers %99 of the use cases

@efiop
Copy link
Contributor Author

efiop commented Sep 11, 2024

If only fal run is of concern then we could do that all on the backend indeed. And can even emit a log message with a warning from there. If everyone is ok with that, I'll send a PR instead of this one.

Thinking about it some more, we could emit logs on the backend for all the cases actually. So sounds like the better option indeed. Closing.

@efiop efiop closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants