Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --ignorerepo option #12

Closed
WorMzy opened this issue Jan 10, 2018 · 11 comments
Closed

Add --ignorerepo option #12

WorMzy opened this issue Jan 10, 2018 · 11 comments

Comments

@WorMzy
Copy link

WorMzy commented Jan 10, 2018

Would you be interested in implementing the option to ignore repository results when downloading, like cower currently has? It currently doesn't seem to be possible to download snapshots of packages in the AUR if there is a package of the same name in a custom repository.

$ auracle search --quiet openxcom                                                                           
openxcom
[...]
$ auracle download openxcom
openxcom is available in myrepo
$ echo $?
1
@AladW
Copy link

AladW commented Jan 10, 2018

#6

@colinkeenan
Copy link

I also need this to be able to replace cower with auracle. I'm confused about the relationship between this and #6.

@AladW
Copy link

AladW commented Feb 8, 2019

I made a mistake, it should be #4.

Repository owner deleted a comment from lisuml Feb 20, 2019
@misterhsp
Copy link

Without --ignorerepo option is for me a switch to auracle senseless.

...

@falconindy
Copy link
Owner

What y'all want isn't an --ignorerepo option, you just want the AUR to take precedence over the binary repos. I hear you. I get it.

This wasn't "possible" with cower because it would have been too damn slow. I think auracle is fast enough to make this happen.

falconindy added a commit that referenced this issue Apr 14, 2019
@falconindy
Ignore pacman repos in package recursion
4cc3463 
Maybe resolves what people really want in #12.
@falconindy
Copy link
Owner

Someone who cares about this, please try the "pony" branch. If it doesn't meet your needs, I'd love to understand why it doesn't.

@WorMzy
Copy link
Author

WorMzy commented Apr 14, 2019 •
edited
Loading

Thanks for the update! I can't speak for the others, but unfortunately, it doesn't scratch my itch.

I have a local repo which contains AUR packages. If the package updates on the AUR, then 'auracle sync' doesn't detect it, because it's not "foreign". cower's --ignorerepo switch which allowed me to treat my custom repo packages as foreign. e.g. 'palemoon' is in my repo, and in the AUR, if I have an older version installed than is available in the AUR, cower can report that to me, auracle can't:

$ cower -u --ignorerepo=wormzy
:: palemoon 28.4.0-1 -> 28.4.1-1
:: softmaker-office-2018-bin 2018.940-1 -> 2018.960-1

auracle reports:

$ auracle sync
softmaker-office-2018-bin 2018.940-1 -> 2018.960-1

If I comment out the wormzy repo in my pacman.conf, auracle can report the version difference:

$ auracle sync
palemoon 28.4.0-1 -> 28.4.1-1
softmaker-office-2018-bin 2018.940-1 -> 2018.960-1

EDIT: tested with the pony branch, auracle ver r220.4cc3463-1

falconindy added a commit that referenced this issue Apr 14, 2019
@falconindy
Avoid pre-filtering local pkgs
a231a7c 
We don't need this -- auracle can chunk large requests to the AUR and
it has a high chance of wrongly filtering out packages in the presence
of unofficial repos that package AUR things.

More fixes for #12.
@falconindy
Copy link
Owner

Thanks WorMzy. I think we can avoid this, too. Could you test again with the next commit (a231a7c)?

@WorMzy
Copy link
Author

WorMzy commented Apr 14, 2019

From my perspective, that seems perfect:

$ auracle sync
softmaker-office-2018-bin 2018.940-1 -> 2018.960-1
palemoon 28.4.0-1 -> 28.4.1-1

Thanks!

@WorMzy WorMzy closed this as completed Apr 14, 2019
@misterhsp
Copy link

wow, that was fast. I can test it only tomorrow

@misterhsp
Copy link

misterhsp commented Apr 14, 2019 •
edited
Loading

If I reinstall from the AUR, is it already included or does it still have to be updated?

Thank you...

falconindy added a commit that referenced this issue Apr 14, 2019
@falconindy
Ignore pacman repos in package recursion and sync operations
d04b9cf 
In #12, users are asking for the --ignorerepo flag to come back, but
what they really want is for Auracle to make the AUR take precedence
over packages known to pacman. This was unwieldy and terribly slow in
cower, but Auracle is fast and not terrible. This commit does two
things:

* Skips discovering the notion of "foreign" packages when calling
  'sync'. We can just send the whole DB to the AUR since Auracle
  understands how to chunk large requests.
* Skips filtering out of packages known to pacman when recursing through
  dependencies. We only error out, suggesting the package is unknown,
  only after both the AUR and pacman (in that order) deny the existence
  of the package.

This should make Auracle play more nicely with unofficial DBs that
contain packages also known to the AUR. Really should add some tests for
this...

Fixes #12.
falconindy added a commit that referenced this issue Sep 4, 2020
@falconindy
Rip out all of our cancellation logic, use sd_event_exit
9e8b12c 
Originally, I wanted to address the following problem:

When a user callback indicates failure, calling CancelAll() means that
we end up (re)invoking a curl socket callback from a socket callback,
leading to a double free (either in sd-event or curl). One possible
backtrace looks like:

    (gdb) bt
->  #0  aur::AurImpl::DispatchSocketCallback (this=0x618000000480, s=<optimized out>, action=4, io=<optimized out>) at ../src/aur/aur.cc:330
    #1  0x00007ffff74fa4e1 in singlesocket () from /usr/lib/libcurl.so.4
    #2  0x00007ffff74fe622 in curl_multi_remove_handle () from /usr/lib/libcurl.so.4
    #3  0x000055555570e833 in aur::AurImpl::FinishRequest (this=<optimized out>, curl=0x623000005500, result=<optimized out>, dispatch_callback=<optimized out>) at ../src/aur/aur.cc:462
    #4  0x0000555555708cc1 in std::__do_visit<std::__detail::__variant::__deduce_visit_result<void>, aur::AurImpl::Cancel(const value_type&)::Visitor, const std::variant<void*, sd_event_source*>&> (__visitor=...) at /usr/include/c++/10.2.0/variant:869
    #5  std::visit<aur::AurImpl::Cancel(const value_type&)::Visitor, const std::variant<void*, sd_event_source*>&> (__visitor=...) at /usr/include/c++/10.2.0/variant:1710
    #6  aur::AurImpl::Cancel (this=0x618000000480, request=...) at ../src/aur/aur.cc:291
    #7  0x00005555557090f6 in aur::AurImpl::CancelAll (this=0x618000000480) at ../subprojects/abseil-cpp-20200225.2/absl/container/internal/raw_hash_set.h:311
    #8  0x000055555570f08d in aur::AurImpl::CheckFinished (this=0x618000000480) at ../src/aur/aur.cc:485
->  #9  0x000055555570f341 in aur::AurImpl::DispatchSocketCallback (this=0x618000000480, s=<optimized out>, action=4, io=<optimized out>) at ../src/aur/aur.cc:332
    #10 0x00007ffff74fb092 in Curl_multi_closed () from /usr/lib/libcurl.so.4
    #11 0x00007ffff74cc631 in Curl_closesocket () from /usr/lib/libcurl.so.4
    #12 0x00007ffff74df551 in Curl_disconnect () from /usr/lib/libcurl.so.4
    #13 0x00007ffff74fc354 in multi_done () from /usr/lib/libcurl.so.4
    #14 0x00007ffff74fcc91 in multi_runsingle () from /usr/lib/libcurl.so.4
    #15 0x00007ffff74fe1d1 in multi_socket () from /usr/lib/libcurl.so.4
    #16 0x00007ffff74fe354 in curl_multi_socket_action () from /usr/lib/libcurl.so.4
    #17 0x000055555570f60d in aur::AurImpl::OnCurlTimer (userdata=0x618000000480) at ../src/aur/aur.cc:401
    #18 0x00007ffff7466b3e in ?? () from /usr/lib/libsystemd.so.0
    #19 0x00007ffff746821e in sd_event_dispatch () from /usr/lib/libsystemd.so.0
    #20 0x00007ffff746a6a9 in sd_event_run () from /usr/lib/libsystemd.so.0
    #21 0x0000555555704bd3 in aur::AurImpl::Wait (this=0x618000000480) at ../src/aur/aur.cc:495
    #22 0x000055555563ee8a in auracle::Auracle::GetOutdatedPackages (this=<optimized out>, args=std::vector of length 0, capacity 0, packages=<optimized out>) at /usr/include/c++/10.2.0/bits/unique_ptr.h:421
    #23 0x0000555555656816 in auracle::Auracle::Outdated (this=<optimized out>, args=..., options=...) at ../src/auracle/auracle.cc:564
    #24 0x0000555555596c7f in main (argc=<optimized out>, argv=<optimized out>) at ../subprojects/abseil-cpp-20200225.2/absl/container/internal/raw_hash_set.h:311

We could do that by making CancelAll() merely schedule another event
that performs the actual cancellation at a later point in order to avoid
the recursion. However, our cancellation logic is all sorts of weird and
makes assumptions about how events are dispatched (i.e. there might be
multiple at a time). Let's just get rid of all of this and use the
sd-event mechanism of sd_event_exit instead.

This does, however (as did the original proposed solution), have the
side effect of logging multiple times because we potentially open up to
5 connections to the AUR at once, e.g.

  $ build/auracle --baseurl http://129.168.255.1 outdated
  error: UNKNOWN: Connection timed out after 10000 milliseconds
  error: UNKNOWN: Connection timed out after 10000 milliseconds

I suppose one way to fix this would be to do response merging on the
backend to match the request splitting. That way, the frontend only gets
one response. I think that comes with a lot of weird potential behaviors
though (handling of partial failures, to mention one). Would be nicer if
the AUR didn't have the crap behavior and could take POST requests in
order to extend the arg limit.

Whatever, this is a weird edge case.

Fixes #82.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@falconindy @WorMzy @colinkeenan @AladW @misterhsp