Fix buldorder recursing when there are no dependencies #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a major problem since the AUR returns an error when the deplist is empty
JAicewizard
force-pushed
the
fix_bulidorder
branch
from
9690647 to
7cb49b7
Compare
|
Thanks. Agree this is a problem (though definitely not a new one). If you're up for adding a unit test for this in test_buildorder.py that'd be hugely appreciated. Otherwise, I can get to this tonight or tomorrow. |
falconindy
reviewed
Sep 3, 2024
|
Done |
|
Thanks. Pushed with a fix to formatting, and made the test actually pass. |
|
Did the tests not pass for you? Thats odd, everything worked for me. But thanks for merging it :) |
|
No, they didn't, and I'm not sure how they could have without the added DB entry for mingw-w64-environment. |
|
Oh I see, I forgot to add it to git, and since its not tracked it didn't warn me. My bad :) |
|
No worries. Thanks for providing the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major problem since the AUR returns an error when the deplist is empty.
To test, try
auracle buildorder mingw-w64-environment