Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(asgi): Improve docstrings, navigation #1697

Merged
merged 1 commit into from
Mar 15, 2020

Conversation

kgriffs
Copy link
Member

@kgriffs kgriffs commented Mar 12, 2020

Summary of Changes

This patch further improves the ASGI docstrings. It also attempts to make navigating long doc pages easier, now that they are starting to become unwieldy with all the additional classes and functions.

Related Issues

#1358

@kgriffs kgriffs requested a review from vytas7 March 12, 2020 03:50
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #1697 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1697   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          47      47           
  Lines        3548    3548           
  Branches      550     550           
======================================
  Hits         3548    3548
Impacted Files Coverage Δ
falcon/testing/helpers.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a04c461...6b7523e. Read the comment docs.

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vytas7 vytas7 merged commit 8d217b1 into falconry:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants