Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Response): support setting Response.status to http.HTTPStatus #1735

Merged
merged 4 commits into from
Jul 31, 2020
Merged

feat(Response): support setting Response.status to http.HTTPStatus #1735

merged 4 commits into from
Jul 31, 2020

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Jul 4, 2020

Closes #1135

@vytas7 vytas7 requested review from kgriffs and jmvrbanac July 4, 2020 15:47
@codecov
Copy link

codecov bot commented Jul 4, 2020 •
edited
Loading

Codecov Report

Merging #1735 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1735   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         5029      5037    +8     
  Branches       820       823    +3     
=========================================
+ Hits          5029      5037    +8
Impacted Files Coverage Δ
falcon/response.py 100.00% <ø> (ø)
falcon/app.py 100.00% <100.00%> (ø)
falcon/util/misc.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873f0d6...1b5fe48. Read the comment docs.

kgriffs
kgriffs approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@kgriffs kgriffs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vytas7 vytas7 merged commit 974fba8 into falconry:master Jul 31, 2020
@vytas7 vytas7 deleted the 1135-support-http.HTTPStatus branch August 20, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgriffs kgriffs kgriffs approved these changes

@jmvrbanac jmvrbanac Awaiting requested review from jmvrbanac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support http.HTTPStatus
2 participants
@vytas7 @kgriffs