Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(http_error): remove deprecated code #1900

Merged
merged 6 commits into from
May 21, 2022

Conversation

jkklapp
Copy link
Contributor

@jkklapp jkklapp commented Apr 4, 2021

Part of #1853

@codecov
Copy link

codecov bot commented Apr 4, 2021

Codecov Report

Merging #1900 (7d2db96) into master (a9ea4a9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1900   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6722      6707   -15     
  Branches      1244      1242    -2     
=========================================
- Hits          6722      6707   -15     
Impacted Files Coverage Δ
falcon/http_error.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9ea4a9...7d2db96. Read the comment docs.

@vytas7 vytas7 changed the title remove deprecated code from http_error module chore(http_error): remove deprecated code Apr 3, 2022
Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jkklapp!
This looks good, we just need to get the newsfragment for #1853 started. The file should be called docs/_newsfragments/1853.breakingchange.rst, and describe what was removed.

@kgriffs
Copy link
Member

kgriffs commented May 19, 2022

@vytas7 I added the fragment

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken the liberty of fixing a misspelling in a removed class's name, looks good otherwise 👍
Thanks @jkklapp & @kgriffs!

@vytas7
Copy link
Member

vytas7 commented May 19, 2022

It seems there is an unrelated error in the CPython 3.5.2 gate. There is an issue to remove 3.5 & 3.6, so either we do that first, or we can try to fix the gate for now.

@CaselIT
Copy link
Member

CaselIT commented May 19, 2022

It seems there is an unrelated error in the CPython 3.5.2 gate. There is an issue to remove 3.5 & 3.6, so either we do that first, or we can try to fix the gate for now.

Probably best to remove 3.5 first, since it does not make much sense to fix the gate to then remove it

@vytas7
Copy link
Member

vytas7 commented May 21, 2022

I've just removed that 3.5.2 gate. We still have the newest 3.5.x gate left that ought to be enough until we remove 3.5 & 3.6 support altogether.

@vytas7 vytas7 merged commit fe5f94b into falconry:master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants