Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(emulated): simplify emulated tests by reusing cibuildwheel #2280

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Aug 20, 2024

A successful run has been demonstrated here: https://github.com/falconry/falcon/actions/runs/10465472709.

@vytas7 vytas7 requested review from kgriffs and CaselIT August 20, 2024 04:51
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3d00f36) to head (6adb153).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2280   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         7170      7170           
  Branches      1260      1260           
=========================================
  Hits          7170      7170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, so basically we create the wheels and piggy back on the test that's run on them. Makes sense to me

@vytas7
Copy link
Member Author

vytas7 commented Aug 20, 2024

Yeah, the idea is to simplify maintenance and hopefully reduce the amount of CI fighting.

@vytas7 vytas7 merged commit 7ed2843 into falconry:master Aug 20, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants