Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated methods, attributes and classes #2282

Merged
merged 16 commits into from
Sep 23, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Aug 20, 2024

Closes #1853.

@maxking: Note that the proposed removal of support for positional arguments in HTTPUnauthorized breaks Mailman.
I have opened MR #1267 on Mailman's side, let's see if it can get merged soon. Otherwise maybe we can make an undocumented exception for HTTPUnauthorized?
The MR has been merged on Mailman's side. All clear 👍

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (afe6c9f) to head (9a7f2fe).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2282   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         7604      7507   -97     
  Branches      1285      1238   -47     
=========================================
- Hits          7604      7507   -97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vytas7 vytas7 changed the title chore: remove deprecated methods, attributes and classes [WORK IN PROGRESS] chore: remove deprecated methods, attributes and classes Sep 22, 2024
@vytas7 vytas7 marked this pull request as ready for review September 22, 2024 12:31
@vytas7 vytas7 requested review from CaselIT and kgriffs September 22, 2024 12:31
Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a suggestion about the docs

falcon/errors.py Outdated Show resolved Hide resolved
@vytas7 vytas7 requested a review from CaselIT September 23, 2024 20:10
@vytas7 vytas7 merged commit 0b9d26c into falconry:master Sep 23, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all deprecated behaviors and shims from 3.x
2 participants