fix(multipart): don't share MultipartParseOptions._DEFAULT_HANDLERS #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myusko
force-pushed
the
myusko-fix-multipart-default-headers
branch
from
206eed7
to
bd3cfbb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2322 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 7499 7502 +3
Branches 1275 1275
=========================================
+ Hits 7499 7502 +3 ☔ View full report in Codecov by Sentry. |
vytas7
reviewed
Sep 5, 2024
vytas7
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Thanks for this fix! 👍
Your initial version was not wrong per se, but it was not functioning correctly since the default UserDict.copy() doesn't properly set up Handlers internals. So I took the liberty of implementing a proper Handlers.copy() method, now it seems to pass.
Now, only a Towncrier newsfragment is remaining before we can move this off Draft (barring one non-critical nitpick in the tests).
CaselIT
previously approved these changes
Sep 6, 2024
vytas7
approved these changes
Sep 6, 2024
CaselIT
approved these changes
Sep 6, 2024
vytas7
added a commit
that referenced
this pull request
Sep 27, 2024
* feat (status_codes) update HTTP status code constants wrt RFC 9110 refactor(response): replace falcon.HTTPPayloadTooLarge with falcon.HTTPContentTooLarge Replace the usage of falcon.HTTPPayloadTooLarge with falcon.HTTPContentTooLarge in the codebase. This change aligns with the recent renaming of the class in the Falcon library. The new class name better reflects the purpose of the error, which is to indicate that the content of the request is too large for the server to process. Closes #2322 * docs(_newsfragments) documented class name change from HTTPPayloadTooLarge to HTTPContentTooLarge * fix(status_codes): bring back removed constant for compatibility, fix ruff * chore: misc touchups * refactor: add a compat alias HTTPPayloadTooLarge ==> HTTPContentTooLarge * docs: tweaks newsfragment for HTTP status code updates --------- Co-authored-by: Vytautas Liuolia <vytautas.liuolia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix a problem, when MultipartParseOptions._DEFAULT_HANDLERS was shared between different instances
Related Issues
Fixes #2293.
Pull Request Checklist
docs/.docs/.versionadded,versionchanged, ordeprecateddirectives.docs/_newsfragments/, with the file name format{issue_number}.{fragment_type}.rst. (Runtowncrier --draftto ensure it renders correctly.)