-
-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mediatypes): reimplement (and unvendor) mimeparse #2348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2348 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 7624 7712 +88
Branches 1246 1267 +21
=========================================
+ Hits 7624 7712 +88 ☔ View full report in Codecov by Sentry. |
The code now has full unit test coverage, but I am still adding more cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I've marked a few minor things
Co-authored-by: Federico Caselli <cfederico87@gmail.com>
…/864.breakingchange.rst` Co-authored-by: Federico Caselli <cfederico87@gmail.com>
Unvendoring and rewriting mimeparse functionality:
python-mimeparse
#2054.I believe the code is more or less complete now, and I'm proposing it as is.
Some things that are, however, known to still be work in progress:
print()
s.ValueError
.Tune the LRU cache decorators, esp on PyPy (where to use the "simple logic" passthrough). Not critical for release -- postponed to post-4.0.