fix(contributing): improve checklist #2351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2351 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 7624 7624
Branches 1246 1246
=========================================
Hits 7624 7624 ☔ View full report in Codecov by Sentry. |
vytas7
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Thanks for looking into this @nithin-sudarsan!
In a pinch, we could simply change to a list, but in this issue we were first of all looking to render something that looks like checkboxes in Sphinx. Could you explore the alternatives?
vytas7
changed the title
|
Thank you for the feedback @vytas7! I will look further into this to see alternative ways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Replaced checklist under https://falcon.readthedocs.io/en/latest/community/contributing.html#reviews with bulleted list.
Related Issues
#2318