Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: update daemonset.yaml (--disable-cri-async) #15

Closed
wants to merge 1 commit into from
Closed

wip: update daemonset.yaml (--disable-cri-async) #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions falco/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ spec:
- --cri
- /run/containerd/containerd.sock
{{- end }}
- --disable-cri-async # @kris-nova default to sync falco mode to eliminate syscall drops
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hard-coding it here, would it be more appropriate to let the user set this flag via Values.extraArgs (on line 66)? Seems like the change here should be a documentation change that informs the user about the flag rather than a hard-coded value.

- -K
- /var/run/secrets/kubernetes.io/serviceaccount/token
- -k
Expand Down