Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(OWNERS): remove inactive approvers #360

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

/kind documentation

Any specific area of the project related to this PR?

What this PR does / why we need it:

For falcosecurity/evolution#157, this PR moves inactive approvers (who had very little or zero contributions over the past 6 months) from approvers to emeritus_approvers in OWNERS.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@poiana poiana added kind/cleanup dco-signoff: yes kind/documentation Improvements or additions to documentation labels Jul 5, 2022
@poiana
Copy link
Contributor

poiana commented Jul 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jasondellaluce
To complete the pull request process, please assign leogr after the PR has been reviewed.
You can assign the PR to them by writing /assign @leogr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

OWNERS Outdated
- leodido
- fntlnz
- kris-nova
- nibalizer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: new line

falco/OWNERS Outdated
reviewers:
- bencer
- nestorsalceda
emeritus_approvers:
- bencer
- nestorsalceda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: new line

@cpanato
Copy link
Member

cpanato commented Jul 5, 2022

and will need to bump the chart version, then i recommend to split in two prs for each chart

@cpanato cpanato closed this Jul 5, 2022
@cpanato cpanato reopened this Jul 5, 2022
@cpanato
Copy link
Member

cpanato commented Jul 5, 2022

ops, sorry pressed the wrong button

jasondellaluce and others added 3 commits July 5, 2022 15:32
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: cpanato <ctadeu@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: cpanato <ctadeu@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@jasondellaluce jasondellaluce force-pushed the cleanup/inactive-owners branch from 6496e2a to 58ea577 Compare July 5, 2022 15:39
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasondellaluce
Copy link
Contributor Author

jasondellaluce commented Jul 15, 2022

and will need to bump the chart version, then i recommend to split in two prs for each chart

@cpanato I think you have a good point here, specially considering that the Falco chart has been recently released and deeply refactored. I'm gonna close this PR and split the OWNERS review in two: falcosecurity/falco#368, falcosecurity/falco#369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes kind/cleanup kind/documentation Improvements or additions to documentation size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants