-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(OWNERS): remove inactive approvers #360
cleanup(OWNERS): remove inactive approvers #360
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jasondellaluce The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OWNERS
Outdated
- leodido | ||
- fntlnz | ||
- kris-nova | ||
- nibalizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new line
falco/OWNERS
Outdated
reviewers: | ||
- bencer | ||
- nestorsalceda | ||
emeritus_approvers: | ||
- bencer | ||
- nestorsalceda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new line
and will need to bump the chart version, then i recommend to split in two prs for each chart |
ops, sorry pressed the wrong button |
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: cpanato <ctadeu@gmail.com> Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: cpanato <ctadeu@gmail.com> Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
6496e2a
to
58ea577
Compare
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please restore fntlnz
https://github.com/falcosecurity/falco/issues/2115#issuecomment-1176045086
@cpanato I think you have a good point here, specially considering that the Falco chart has been recently released and deeply refactored. I'm gonna close this PR and split the OWNERS review in two: falcosecurity/falco#368, falcosecurity/falco#369 |
What type of PR is this?
/kind cleanup
/kind documentation
Any specific area of the project related to this PR?
What this PR does / why we need it:
For falcosecurity/evolution#157, this PR moves inactive approvers (who had very little or zero contributions over the past 6 months) from
approvers
toemeritus_approvers
in OWNERS.Which issue(s) this PR fixes:
Special notes for your reviewer: