-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(OWNERS): remove nestorsalceda #386
update(OWNERS): remove nestorsalceda #386
Conversation
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@@ -1,3 +1,2 @@ | |||
emeritus_approvers: | |||
- bencer | |||
- nestorsalceda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is ok to remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replicated the same changes of #373 from @nestorsalceda due to falcosecurity/falco#2143 (comment).
From falcosecurity/falco#2143, he asks to be removed from everywhere. The linked PRs also involve emeritus_approvers
without providing specific rationale for that section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, ok 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
thanks for all nestor!
LGTM label has been added. Git tree hash: edb879af826cdcce10dfbb963277766d97f5c819
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
What this PR does / why we need it:
This supersedes #373 due to it being not mergeable. See falcosecurity/falco#2143 (comment).
Which issue(s) this PR fixes:
Special notes for your reviewer:
/cc @falcosecurity/charts-maintainers