Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing mocks break go mod tidy when client-go is used in other projects #46

Closed
leogr opened this issue Jun 24, 2020 · 0 comments
Closed

missing mocks break go mod tidy when client-go is used in other projects #46

leogr opened this issue Jun 24, 2020 · 0 comments
Assignees
@leogr
Labels
kind/bug Something isn't working

Comments

@leogr
Copy link
Member

leogr commented Jun 24, 2020

Describe the bug/How to reproduce it

In another go project:

go get -u github.com/falcosecurity/client-go@master

Then run go mod tidy:

 [redacted] imports
	github.com/falcosecurity/client-go/pkg/client tested by
	github.com/falcosecurity/client-go/pkg/client.test imports
	github.com/falcosecurity/client-go/pkg/api/version/mocks: module github.com/falcosecurity/client-go@latest found (v0.1.0), but does not contain package github.com/falcosecurity/client-go/pkg/api/version/mocks

Expected behaviour

No errors when running go mod tidy

Additional context

This is breaking the release pipeline of falco-exporter

/assign
@leogr leogr added the kind/bug Something isn't working label Jun 24, 2020
@leogr leogr mentioned this issue Jun 24, 2020
Merged
leodido added a commit that referenced this issue Jun 30, 2020
@leodido @fntlnz
update(pkg/api/**/mocks): API mocks (for testing) should be checked in
7287714 
Fixes #46

Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@poiana poiana closed this as completed in 71d080b Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leogr leogr

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leogr