Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Puppet module metadata and add link to module source #143

Closed

Conversation

genebean
Copy link

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area integrations

What this PR does / why we need it:

This PR updates Puppet module metadata and adds a link to the module's source. The link added to the readme is for the benefit of people viewing https://forge.puppet.com/modules/sysdig/falco

Which issue(s) this PR fixes:

Relates to #142

Special notes for your reviewer:

A release to the Puppet Forge will be needed to finish fixing the linked issue.

@poiana
Copy link
Contributor

poiana commented May 19, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: genebean
To complete the pull request process, please assign fntlnz after the PR has been reviewed.
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from krisnova and leodido May 19, 2022 17:06
@poiana
Copy link
Contributor

poiana commented May 19, 2022

Welcome @genebean! It looks like this is your first PR to falcosecurity/evolution 🎉

@poiana poiana added the size/XS label May 19, 2022
The link added to the readme is for the benefit of people viewing
https://forge.puppet.com/modules/sysdig/falco

Signed-off-by: Gene Liverman <gene.liverman+06301990@puppet.com>
@genebean
Copy link
Author

Closing as I have rewored this code into a standalone module. The current module cannot be installed via git because it is not in the root of a repo / a repo by itself.

@genebean genebean closed this May 23, 2022
@genebean genebean deleted the update_metadata_and_links branch May 23, 2022 22:22
@maxgio92
Copy link
Member

Ok, thanks for the update @genebean

@genebean
Copy link
Author

@maxgio92 FWIW, falcosecurity/falco#2005 has details and https://forge.puppetlabs.com/modules/puppet/falco has been released

@maxgio92
Copy link
Member

Thanks @genebean! I left some comments on Falco #2005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants