Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(hooks/UseWasm): update scap option #57

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

Rohith-Raju
Copy link
Collaborator

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area frontend

What this PR does / why we need it:
This PR updates -e option to use -o engine.kind=replay -o engine.replay.capture_file=some_file.scap for running Falco with snap file.

Which issue(s) this PR fixes:

Fixes #55

Special notes for your reviewer:

Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
@poiana poiana added kind/bug Something isn't working dco-signoff: yes size/XS labels Apr 17, 2024
@poiana poiana requested review from jasondellaluce and leogr April 17, 2024 14:56
@poiana
Copy link
Contributor

poiana commented Apr 22, 2024

LGTM label has been added.

Git tree hash: ec6a09412e453466ea9f68642a636bd009e8150b

@poiana poiana merged commit 8b9414e into falcosecurity:main Apr 22, 2024
3 checks passed
@poiana
Copy link
Contributor

poiana commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, Rohith-Raju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run with scap fails with "Error: Option ‘e’ does not exist"
4 participants