cleanup(metrics): improve prometheus and plugin metrics info #1328
Conversation
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
|
I guess the added plugin section at least tempers expectations for now. Not sure if I understand the design behind it and how it is supposed to look in the future. Will add a comment to #3194 for clarity. |
|
@sgaist: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| - When running Falco with a plugin only on Linux (without using the syscalls event source), it currently doesn't work well due to some issues in Falco's capture initialization phase. We are working on resolving remaining issues by Falco 0.39.0 (see this [issue](https://github.com/falcosecurity/falco/issues/3194#issuecomment-2111009270)). Therefore, the following fields are not available when running Falco with a plugin only on Linux: | ||
| - `falcosecurity_falco_kernel_release_info` | ||
| - `falcosecurity_evt_hostname_info` | ||
| - `falcosecurity_falco_start_timestamp_nanoseconds` | ||
| - `falcosecurity_falco_host_boot_timestamp_nanoseconds` | ||
| - `falcosecurity_falco_host_num_cpus_total` | ||
| - `falcosecurity_falco_duration_seconds_total` | ||
| - `falcosecurity_falco_cpu_usage_ratio` (broken given we don't initialize some of the above info) |
There was a problem hiding this comment.
The explanation is interesting but for now I would simply indicate that, as of 0.38.0, it is not possible to run plugins without syscalls and use Prometheus metrics. You can link the issue if people need more details.
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: incertum, LucaGuerra, sgaist The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 7b77c8d9d3d80d525d54af64ddace00f2c3d143d
|
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
Improve prometheus and plugin metrics info, see falcosecurity/falco#3229
@sgaist would you mind helping with the review? Thank you!
@sboschman are these updates ok? Do you have additional input?
CC @Issif
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: