Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): Install support and new blog #184

Merged
merged 12 commits into from
May 18, 2020
Merged

feat(docs): Install support and new blog #184

merged 12 commits into from
May 18, 2020

Conversation

krisnova
Copy link
Contributor

Refactor from the last Falco call regarding install methods

Signed-off-by: Kris Nova kris@nivenly.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind translation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

What this PR does / why we need it:

This updates the website with some much-needed changes around official support.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana requested review from fntlnz and mfdii April 21, 2020 00:10
@krisnova
Copy link
Contributor Author

I can demo this on the next call if needed

@leogr
Copy link
Member

leogr commented Apr 21, 2020

I can demo this on the next call if needed

Yes, please!

This was referenced Apr 21, 2020
Closed
Merged
@nibalizer nibalizer mentioned this pull request May 1, 2020
Closed
@leodido leodido mentioned this pull request May 4, 2020
Closed
@leogr
Copy link
Member

leogr commented May 4, 2020

Hey @kris-nova

Since falcosecurity/falco#1172 has been merged, we should add instructions about how to use the driverloader docker image.
Using that is really easy:

docker run --rm -i -t -v /dev:/host/dev -v /proc:/host/proc:ro -v /boot:/host/boot:ro -v /lib/modules:/host/lib/modules:ro -v /usr:/host/usr:ro falcosecurity/driverloader

I could add that to the documentation, but I'm not sure which is the right place.

Also:

Finally, the next Falco release is going to happen within 2 weeks, thus I believe this PR is becoming a high priority now.

Let me know how I can help out.

@leogr
Copy link
Member

leogr commented May 11, 2020 •
edited
Loading

See also:

@krisnova @leogr
feat(docs): Install support and new blog
891fab7 
Refactor from the last Falco call regarding install methods

Signed-off-by: Kris Nova <kris@nivenly.com>
@leogr leogr force-pushed the install-refactor branch from e8c572b to 891fab7 Compare May 15, 2020 08:17
@leogr
Copy link
Member

leogr commented May 15, 2020

I'm working in this PR as discussed
/hold

@leogr
Copy link
Member

leogr commented May 15, 2020

/assign leogr

@leogr leogr self-assigned this May 15, 2020
leogr added 2 commits May 15, 2020 10:46
@leogr
fix(docs): correct links
d210fa8 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
fix(docs): complete installation and downloading
bfb61f9 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr force-pushed the install-refactor branch from d5fdf7f to bfb61f9 Compare May 15, 2020 11:29
leogr and others added 3 commits May 15, 2020 15:48
@leogr
update(docs): minor improvements
48ba985 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr @leodido @fntlnz
update(docs): install and download sections reviewed
31fe3c6 
co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr @leodido @fntlnz
update(docs): event-source drivers section
629c077 
co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr force-pushed the install-refactor branch 2 times, most recently from 4750419 to 4a488ae Compare May 15, 2020 16:25
@leogr @leodido @fntlnz
update(docs): running section
94cf42b 
co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@fntlnz
Copy link
Contributor

fntlnz commented May 18, 2020

In the CentOS/RHEL/EC2 Linux/Fedora section under install I would also like to add Amazon Linux 2 and 1 since we actively test them before each release

@fntlnz
Copy link
Contributor

fntlnz commented May 18, 2020

Wrapping this up to later add to this document:

For the systemd units, it actually works because does is using the systemd-sysv-generator to wrap init.d scripts into systemd units.

Read more here:

fntlnz
fntlnz previously approved these changes May 18, 2020
View reviewed changes
@fntlnz
Copy link
Contributor

fntlnz commented May 18, 2020

/hold

@fntlnz
Copy link
Contributor

fntlnz commented May 18, 2020

Approved but adding an hold to merge this at the exact moment we cut the release.

@poiana poiana added the lgtm label May 18, 2020
@poiana
Copy link

poiana commented May 18, 2020

LGTM label has been added.

Git tree hash: 9f82d0e2c6213c3b6eace101f5ce451e7eda0617

leodido
leodido previously approved these changes May 18, 2020
View reviewed changes
leogr
leogr reviewed May 18, 2020
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes

config.yaml Outdated Show resolved Hide resolved
content/en/docs/installation.md Outdated Show resolved Hide resolved
@leogr
update(docs): bump version
a93f55b 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr dismissed stale reviews from leodido and fntlnz via a93f55b May 18, 2020 12:16
@poiana poiana removed lgtm labels May 18, 2020
leogr and others added 2 commits May 18, 2020 14:27
@leogr @fntlnz @krisnova
fix(docs): corrections from review
9654136 
co-authored-by: Lorenzo Fontana <lo@linux.com>
co-authored-by: Kris Nova <kris@nivenly.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr @fntlnz
update(docs): explain how to use images with fully/least privileged
e9d5a10 
co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr force-pushed the install-refactor branch from 824d757 to e9d5a10 Compare May 18, 2020 14:51
leogr added 2 commits May 18, 2020 17:35
@leogr
update(docs): recommended docker usage and refinements
d0223e7 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
update(docs): promote install driver section
3c85970 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@poiana poiana added the lgtm label May 18, 2020
@poiana
Copy link

poiana commented May 18, 2020

LGTM label has been added.

Git tree hash: 14f944ebabba755ef680d16b3fea063ca19a0cd3

@poiana
Copy link

poiana commented May 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kris-nova, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented May 18, 2020

/hold cancel

@poiana poiana merged commit 9ad5bbc into master May 18, 2020
@poiana poiana deleted the install-refactor branch May 18, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr left review comments

@leodido leodido leodido approved these changes

@fntlnz fntlnz fntlnz left review comments

@mfdii mfdii Awaiting requested review from mfdii

Assignees

@leodido leodido

@fntlnz fntlnz

@leogr leogr

Labels
approved area/blog area/documentation dco-signoff: yes kind/cleanup lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@krisnova @leogr @poiana @maxgio92 @fntlnz @leodido