Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: update(content): update running docs for Falco 0.34. #785

Closed
wants to merge 1 commit into from

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 10, 2023

What type of PR is this?

/kind cleanup
/kind content

Any specific area of the project related to this PR?

/area documentation

What this PR does / why we need it:

Falco 0.34 changed the way we manage our deb/rpm systemd units: falcosecurity/falco#2242.
Update doc accordingly.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana
Copy link

poiana commented Jan 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FedeDP
Once this PR has been reviewed and has the lgtm label, please assign jasondellaluce for approval by writing /assign @jasondellaluce in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from mstemm and vjjmiras January 10, 2023 09:23
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 10, 2023

Keep this on hold until Falco 0.34.
/hold

@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 10, 2023

/cc @leogr

@poiana poiana requested a review from leogr January 10, 2023 09:23
@Andreagit97
Copy link
Member

Closed in favor of #799

@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 30, 2023

/close
Thank you Andrea!

@poiana poiana closed this Jan 30, 2023
@poiana
Copy link

poiana commented Jan 30, 2023

@FedeDP: Closed this PR.

In response to this:

/close
Thank you Andrea!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FedeDP FedeDP deleted the update/running_docs branch January 30, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants