debug actions true/false

Signed-off-by: Luca Guerra <luca@guerra.sh>
falcosecurity · Mar 26, 2024 · 2d1739e · 2d1739e
1 parent b4d7df7
commit 2d1739e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,15 +22,13 @@ jobs:
     with:
       arch: x86_64
       version: ${{ needs.fetch-version.outputs.version }}
-      sanitizers: 'true'
 
   build-dev-packages-arm64:
     needs: [fetch-version]
     uses: ./.github/workflows/reusable_build_packages.yaml
     with:
       arch: aarch64
       version: ${{ needs.fetch-version.outputs.version }}
-      sanitizers: 'true'
 
   test-dev-packages:
     needs: [fetch-version, build-dev-packages]
@@ -84,6 +82,7 @@ jobs:
       arch: x86_64
       git_ref: ${{ github.event.pull_request.head.sha }}
       minimal: false
+      sanitizers: true
       build_type: Debug
       cmd: "echo $(build/userspace/falco/falco -c ./falco.yaml --version | grep 'Engine:' | awk '{print $2}') $(echo $(build/userspace/falco/falco -c ./falco.yaml --version | grep 'Schema version:' | awk '{print $3}') $(build/userspace/falco/falco -c ./falco.yaml --list --markdown | grep '^`' | sort) $(build/userspace/falco/falco -c ./falco.yaml --list-events | sort) | sha256sum)"
 

diff --git a/.github/workflows/reusable_build_dev.yaml b/.github/workflows/reusable_build_dev.yaml
@@ -14,6 +14,10 @@ on:
         description: Minimal build
         required: true
         type: boolean
+      sanitizers:
+        description: Enable sanitizer support
+        required: true
+        type: boolean
       build_type:
         description: One of 'Debug' or 'Release'
         required: true
@@ -59,6 +63,8 @@ jobs:
             -DBUILD_BPF=${{ inputs.minimal == true && 'OFF' || 'ON' }} \
             -DBUILD_DRIVER=${{ inputs.minimal == true && 'OFF' || 'ON' }} \
             -DMINIMAL_BUILD=${{ inputs.minimal == true && 'ON' || 'OFF' }} \
+            -DUSE_ASAN=${{ inputs.sanitizers == true && 'ON' || 'OFF' }} \
+            -DUSE_UBSAN=${{ inputs.sanitizers == true && 'ON' || 'OFF' }} \
             -DUSE_BUNDLED_DEPS=Off \
             -DUSE_BUNDLED_NLOHMANN_JSON=On \
             -DUSE_BUNDLED_CXXOPTS=On \

diff --git a/.github/workflows/reusable_build_packages.yaml b/.github/workflows/reusable_build_packages.yaml
@@ -72,6 +72,9 @@ jobs:
           curl -L https://github.com/Kitware/CMake/releases/download/v3.22.5/cmake-3.22.5-linux-$(uname -m).tar.gz \
             | tar --directory=/usr --strip-components=1 -xzp
 
+      - name: Check sanitizer value
+        run: echo "${{ inputs.sanitizers }}"
+
       - name: Prepare project
         run: |
           source /opt/rh/devtoolset-9/enable
@@ -83,7 +86,7 @@ jobs:
               -DMODERN_BPF_SKEL_DIR=/tmp \
               -DBUILD_DRIVER=Off \
               -DBUILD_BPF=Off \
-              ${{ (inputs.sanitizers == 'true' && '-DUSE_ASAN=On -DUSE_UBSAN=On' || '' ) }} \
+              ${{ (inputs.sanitizers == true && '-DUSE_ASAN=On -DUSE_UBSAN=On') || ''  }} \
               -DFALCO_VERSION=${{ inputs.version }}
 
       - name: Build project