fix(userspace/falco): adopt stricter memory order semantics

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
falcosecurity · Sep 12, 2022 · 9c184af · 9c184af
1 parent d11aec2
commit 9c184af
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/userspace/falco/app_actions/process_events.cpp b/userspace/falco/app_actions/process_events.cpp
@@ -97,8 +97,8 @@ application::run_result application::do_inspect(
 	{
 		rc = inspector->next(&ev);
 
-		if(m_state->terminate.load(std::memory_order_acquire)
-			|| m_state->restart.load(std::memory_order_acquire))
+		if(m_state->terminate.load(std::memory_order_seq_cst)
+			|| m_state->restart.load(std::memory_order_seq_cst))
 		{
 			break;
 		}

diff --git a/userspace/falco/application.cpp b/userspace/falco/application.cpp
@@ -69,7 +69,7 @@ void application::terminate()
 {
 	if(m_state != nullptr)
 	{
-		m_state->terminate.store(true, std::memory_order_release);
+		m_state->terminate.store(true, std::memory_order_seq_cst);
 	}
 }
 
@@ -87,7 +87,7 @@ void application::restart()
 {
 	if(m_state != nullptr)
 	{
-		m_state->restart.store(true, std::memory_order_release);
+		m_state->restart.store(true, std::memory_order_seq_cst);
 	}
 }
 

diff --git a/userspace/falco/webserver.cpp b/userspace/falco/webserver.cpp
@@ -66,7 +66,7 @@ void falco_webserver::start(
     }
 
     std::atomic<bool> failed;
-    failed.store(false, std::memory_order_relaxed);
+    failed.store(false, std::memory_order_release);
     m_server_thread = std::thread([this, listen_port, &failed]
     {
         try