Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badges for "dev" package are not reporting the correct version #1672

Closed
leogr opened this issue Jun 9, 2021 · 17 comments
Closed

Badges for "dev" package are not reporting the correct version #1672

leogr opened this issue Jun 9, 2021 · 17 comments
Labels
Milestone

Comments

@leogr
Copy link
Member

leogr commented Jun 9, 2021

Describe the bug

As per the title.

How to reproduce it

Look at the README.md 👇
Screenshot from 2021-06-09 17-30-47

Expected behaviour

Badges should report the latest version on the master branch according to the following format:
x.y.z-N+hash

Where:

  • x.y.z the latest released version
  • N is the number of commit since the latest released version
  • hash is the ID of the latest commit on the master (first 7 digits)
@leogr leogr added the kind/bug label Jun 9, 2021
@poiana
Copy link
Contributor

poiana commented Sep 7, 2021

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member Author

leogr commented Sep 15, 2021

/remove-lifecycle stale

@jasondellaluce
Copy link
Contributor

Hey @leogr, has this been fixed? I see the badges render as expected right now.

@leogr
Copy link
Member Author

leogr commented Nov 10, 2021

Hey @jasondellaluce

IIRC, it's partially fixed. It might not work under some circumstances. Basically, we pick the last version by relying on the S3 bucket ordering which may not reflect the version order.

@poiana
Copy link
Contributor

poiana commented Feb 8, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member Author

leogr commented Feb 8, 2022

/remove-lifecycle stale

I confirm a similar issue is still present. Basically, it seems to me filenames are ordered lexicographically.
So falco-0.30.0-19+f7893fb-x86_64.deb will come after than falco-0.30.0-177+f86423d-x86_64.deb that's not ok for our use case (you can check out the full order list here).

@poiana
Copy link
Contributor

poiana commented May 9, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member Author

leogr commented May 13, 2022

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Aug 11, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member Author

leogr commented Aug 12, 2022

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Nov 10, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Dec 10, 2022

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@leogr
Copy link
Member Author

leogr commented Dec 16, 2022

/remove-lifecycle rotten

cc @FedeDP

@poiana
Copy link
Contributor

poiana commented Mar 16, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Mar 16, 2023

/remove-lifecycle stale

@leogr
Copy link
Member Author

leogr commented Jun 6, 2023

In the end, the best option was to remove them from the README.
We will work on a better way to document how to use dev packages.
/milestone 0.36.0

/close

@poiana poiana closed this as completed Jun 6, 2023
@poiana poiana added this to the 0.36.0 milestone Jun 6, 2023
@poiana
Copy link
Contributor

poiana commented Jun 6, 2023

@leogr: Closing this issue.

In response to this:

In the end, the best option was to remove them from the README.
We will work on a better way to document how to use dev packages.
/milestone 0.36.0

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants