Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log rule expansion under log_level=debug upon startup #1814

Closed
josb opened this issue Dec 3, 2021 · 17 comments
Closed

Log rule expansion under log_level=debug upon startup #1814

josb opened this issue Dec 3, 2021 · 17 comments

Comments

@josb
Copy link

josb commented Dec 3, 2021

Motivation
It would be great to have the ability to see rule expansions printed, especially with complex rules using lists, macros and exceptions that are being augmented using append: true. This so the author can make sure that they are as desired.

Feature

When running falco with --option log_level=debug I would like falco to emit the expanded rules after reading all config files.

Alternatives

None?

Additional context

None?

@poiana
Copy link
Contributor

poiana commented Mar 3, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@jasondellaluce
Copy link
Contributor

/remove-lifecycle stale

@jasondellaluce
Copy link
Contributor

Hey @josb, I recently took on refactoring the rule loader, and now it should be quite easier to add a feature like this. Do you think it would make sense to make this available only with the -v verbose option? Also, would you prefer this to happen for all rules, or having a selective CLI option to print only one?

@josb
Copy link
Author

josb commented Apr 22, 2022

Hi @jasondellaluce , thanks for doing that! I think putting this under -v would be fine as it's really a debugging aid.Not sure if the extra effort for a CLI option to print a single rule is needed, your call :-)

@poiana
Copy link
Contributor

poiana commented Jul 21, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Aug 20, 2022

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@poiana
Copy link
Contributor

poiana commented Sep 19, 2022

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana
Copy link
Contributor

poiana commented Sep 19, 2022

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana closed this as completed Sep 19, 2022
@jasondellaluce
Copy link
Contributor

/reopen

/remove-lifecycle rotten

@poiana poiana reopened this Sep 20, 2022
@poiana
Copy link
Contributor

poiana commented Sep 20, 2022

@jasondellaluce: Reopened this issue.

In response to this:

/reopen

/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Dec 19, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Jan 18, 2023

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@jasondellaluce
Copy link
Contributor

/remove-lifecycle rotten

@poiana
Copy link
Contributor

poiana commented Apr 18, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented May 18, 2023

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@Andreagit97
Copy link
Member

Andreagit97 commented May 18, 2023

It will be addressed by this PR: #2544 🎉
Moreover, this issue seems already summarized here #2372
Can we close this?

@josb
Copy link
Author

josb commented May 18, 2023

I think so, yes. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants