Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falco validation does not catch an exception that is not defined correctly #2354

Closed
ben-m-lucas opened this issue Jan 12, 2023 · 16 comments · Fixed by #3133
Closed

Falco validation does not catch an exception that is not defined correctly #2354

ben-m-lucas opened this issue Jan 12, 2023 · 16 comments · Fixed by #3133
Labels
Milestone

Comments

@ben-m-lucas
Copy link

Describe the bug

If a falco rule is appending an exception and defines the exception with a property of value, it passes falco validation even though it is not valid.

How to reproduce it
The following test file can be used:
testCase.yaml

- rule: Test rule with exception append
  desc: A shell was used as the entrypoint/exec point into a container with an attached terminal.
  condition: >
    evt.type=setuid
  output: >
    Test output
  exceptions:
  - name: image_suffix
    fields: [container.image.repository]
    comps: [endswith]
    values:
    - [test]
  priority: NOTICE
  tags: [container]
  
- rule: Test rule with exception append
  exceptions:
    - name: image_suffix
      value: secure-inline-scan
  append: true

Run falco -V testCase.yaml

Falco responds that this file is ok.

Expected behaviour
An error message should be returned that the rule is not valid.

  • Falco version:
    Falco version: 0.33.1
    Libs version: 0.9.2
    Plugin API: 2.0.0
    Driver:
    API version: 2.0.0
    Schema version: 2.0.0
    Default driver: 3.0.1+driver

  • System info:
    Falco version: 0.33.1
    Libs version: 0.9.2
    Plugin API: 2.0.0
    Driver:
    API version: 2.0.0
    Schema version: 2.0.0
    Default driver: 3.0.1+driver

  • Cloud provider or hardware configuration:

  • OS:
    PRETTY_NAME="Debian GNU/Linux 10 (buster)"
    NAME="Debian GNU/Linux"
    VERSION_ID="10"
    VERSION="10 (buster)"
    VERSION_CODENAME=buster
    ID=debian
    HOME_URL="https://www.debian.org/"
    SUPPORT_URL="https://www.debian.org/support"
    BUG_REPORT_URL="https://bugs.debian.org/"

  • Kernel:
    Linux 678de6959a21 5.15.79.1-microsoft-standard-WSL2 Digwatch compiler #1 SMP Wed Nov 23 01:01:46 UTC 2022 x86_64 GNU/Linux

  • Installation method:
    used docker image falcosecurity/falco;latest

Additional context

@jasondellaluce
Copy link
Contributor

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone Jan 13, 2023
@poiana
Copy link
Contributor

poiana commented Apr 13, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Apr 13, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

2 similar comments
@poiana
Copy link
Contributor

poiana commented Apr 13, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Apr 13, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@jasondellaluce
Copy link
Contributor

/remove-lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented May 29, 2023

/milestone 0.36.0

@poiana poiana modified the milestones: 0.35.0, 0.36.0 May 29, 2023
@FedeDP
Copy link
Contributor

FedeDP commented May 29, 2023

@jasondellaluce did you have the time, by chance, to work on this?

@jasondellaluce
Copy link
Contributor

@FedeDP unfortunately not, we'll need to set this for the next milestone.

@FedeDP
Copy link
Contributor

FedeDP commented May 29, 2023

No problem man ❤️

@poiana
Copy link
Contributor

poiana commented Aug 27, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@jasondellaluce
Copy link
Contributor

/remove-lifecycle stale

@Andreagit97 Andreagit97 modified the milestones: 0.36.0, TBD Aug 31, 2023
@poiana
Copy link
Contributor

poiana commented Nov 29, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Feb 28, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Feb 28, 2024

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants