new(engine): add warning when appending an exception with no values #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
jasondellaluce
previously approved these changes
Mar 25, 2024
|
LGTM label has been added. Git tree hash: 0163b1c1ae43de80f9c60370d9bfe16c018233d3
|
LucaGuerra
reviewed
Mar 25, 2024
LucaGuerra
reviewed
Mar 25, 2024
Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
mrgian
force-pushed
the
warning-append-no-values
branch
from
fc57b79 to
ce69829
Compare
Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
mrgian
force-pushed
the
warning-append-no-values
branch
from
ce69829 to
55444fb
Compare
LucaGuerra
approved these changes
Mar 26, 2024
|
LGTM label has been added. Git tree hash: a19f926c9d029f485d2beb87c51a27a771be05a3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, LucaGuerra, mrgian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.38.0 |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
Any specific area of the project related to this PR?
/area engine
/area tests
What this PR does / why we need it:
Adds a warning when a rule appends exceptions with no values.
Can be useful when an appended rule has a miswritten field.
Which issue(s) this PR fixes: #2354
Fixes #2354
Special notes for your reviewer:
Does this PR introduce a user-facing change?: