Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] Support regex within rules #438

Closed
harrysx opened this issue Oct 5, 2018 · 15 comments
Closed

[New Feature] Support regex within rules #438

harrysx opened this issue Oct 5, 2018 · 15 comments
Assignees
Milestone

Comments

@harrysx
Copy link

harrysx commented Oct 5, 2018

Regex support will be useful for matching multiple conditions, for example a single rule to match

/var/log-6456546/1
/var/log-3566456/1
/var/log-5686786/1

Or:
1.1.1.1
1.1.2.1
1.1.3.1

@fntlnz
Copy link
Contributor

fntlnz commented Aug 7, 2019

@harrysx I'm closing this one since no one expressed interest in making this happen. Feel free to continue the discussion or send a PR with this feature regardless, in that case reopen the issue please.

@fntlnz fntlnz closed this as completed Aug 7, 2019
@tspearconquest
Copy link
Contributor

This would be helpful to have. Could you consider to reopen it?

@jasondellaluce
Copy link
Contributor

@tspearconquest do you have specific use cases in mind? I can reopen this issue for you if you want.

My gut feeling is that nobody ever approached the problem for various technical issues:

  • C++ doesn't have solid standard regex support, but we overcame this issue last year by adopting the RE2 library
  • Evaluating regular expressions definitely has a non-negligible performance cost that we may not be able to accept in Falco rules. I think this has been the biggest blocker in the past, and this also justify the existence of the more lightweight operators startswith, endswith, contains, glob, and so on. If we ever get to actual regular expressions, for sure we will not support backtracking. Do you have a use case in mind that's not achievable with what we have right now?

@tspearconquest
Copy link
Contributor

tspearconquest commented Apr 7, 2023 via email

@jasondellaluce
Copy link
Contributor

Let's keep this open just so that's visible to other community members as well. However, I don't want to set any expectation about bringing this feature to mainline before having measured the performance tradeoffs.

/reopen

@poiana poiana reopened this Apr 7, 2023
@poiana
Copy link

poiana commented Apr 7, 2023

@jasondellaluce: Reopened this issue.

In response to this:

Let's keep this open just so that's visible to other community members as well. However, I don't want to set any expectation about bringing this feature to mainline before having measured the performance tradeoffs.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasondellaluce jasondellaluce changed the title Support regex within rules [New Feature] Support regex within rules Apr 7, 2023
@poiana
Copy link

poiana commented Jul 6, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@tspearconquest
Copy link
Contributor

/remove-lifecycle stale

@Andreagit97 Andreagit97 added this to the TBD milestone Aug 31, 2023
@gccli
Copy link

gccli commented Dec 21, 2023

regex match pods name of daemonset or statefulset maybe very useful

@poiana
Copy link

poiana commented Mar 20, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@tspearconquest
Copy link
Contributor

/remove-lifecycle stale

@poiana
Copy link

poiana commented Jun 18, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@jasondellaluce
Copy link
Contributor

/remove-lifecycle stale

@leogr
Copy link
Member

leogr commented Aug 28, 2024

/assign @jasondellaluce

@jasondellaluce
Copy link
Contributor

Closing this as the feature has been addressed in falcosecurity/libs#1904. Please anyone feel free to reopen this issue in case we haven't reached a satisfactory state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants