Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete quoting for parameters of some CMake commands #79

Closed
elfring opened this issue May 19, 2016 · 1 comment · Fixed by #84
Closed

Complete quoting for parameters of some CMake commands #79

elfring opened this issue May 19, 2016 · 1 comment · Fixed by #84
Assignees
@mstemm

Comments

@elfring
Copy link

elfring commented May 19, 2016

Some parameters (like "${SYSDIG_DIR}/driver" and "${PROJECT_SOURCE_DIR}/scripts/debian/falco") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.
mstemm added a commit that referenced this issue May 24, 2016
@mstemm
Quote path variables that may contain spaces.
2237532 
Make sure that references to variables that may be paths (which in turn
may contain spaces) are quoted, so cmake won't break on the spaces.

This fixes #79.
@mstemm mstemm mentioned this issue May 24, 2016
Merged
@mstemm mstemm self-assigned this May 24, 2016
@mstemm
Copy link
Contributor

mstemm commented May 24, 2016

Thanks, fix otw.

@spaceportpw spaceportpw mentioned this issue Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mstemm mstemm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Quote path variables that may contain spaces. falcosecurity/falco
2 participants
@elfring @mstemm