Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): tags and stable image #1018

Merged
merged 2 commits into from
Feb 25, 2020
Merged

fix(docker): tags and stable image #1018

merged 2 commits into from
Feb 25, 2020

Conversation

krisnova
Copy link
Contributor

@krisnova krisnova commented Jan 23, 2020 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1015

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(docker): updating `stable` and `local` images to run from `debian:stable`

@krisnova
Fixing falco:stable image
0807e6b 
 - Updating stable image to pull from `debian:stable`
 - Updating maintainer label in all Dockerfiles to include `LABEL maintainer="cncf-falco-dev@lists.cncf.io"`

Signed-off-by: Kris Nova <kris@nivenly.com>
@krisnova
Updating falco:local
55c89c2 
 - Using `debian:stable` for the local image as well

Signed-off-by: Kris Nova <kris@nivenly.com>
@poiana poiana requested review from fntlnz and mfdii January 23, 2020 18:27
@krisnova
Copy link
Contributor Author

Note: I tested this locally and the builds were successful. I also pushed krisnova/falco-debian:stable to my container registry.

docker pull krisnova/falco-debian:stable

@krisnova krisnova changed the title Fixing stable image Fixing stable and local images Jan 23, 2020
@krisnova krisnova mentioned this pull request Jan 23, 2020
Closed
@fntlnz
Copy link
Contributor

fntlnz commented Jan 23, 2020

This needs further discussion and testing, the image must be tested on kernels <= 4.16 and be able to compile the driver and bpf probe.

@poiana
Copy link
Contributor

poiana commented Jan 24, 2020

@ravishankarsrrav: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leodido leodido changed the base branch from dev to master February 3, 2020 15:14
@poiana poiana added the lgtm label Feb 25, 2020
@poiana
Copy link
Contributor

poiana commented Feb 25, 2020

LGTM label has been added.

Git tree hash: fe4b008e293a235afe9c6025028745d41ff60b0b

@fntlnz
Copy link
Contributor

fntlnz commented Feb 25, 2020

/cc @leodido

@poiana poiana requested a review from leodido February 25, 2020 09:49
leodido
leodido approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana
Copy link
Contributor

poiana commented Feb 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido, ravishankarsrrav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido
Copy link
Member

leodido commented Feb 25, 2020

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Feb 25, 2020
@poiana poiana merged commit 9eeed59 into master Feb 25, 2020
@poiana poiana deleted the fixing-stable-image branch February 25, 2020 12:21
@krisnova krisnova changed the title Fixing stable and local images fix(docker): tags and stable image Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravishankarsrrav ravishankarsrrav ravishankarsrrav approved these changes

@fntlnz fntlnz fntlnz approved these changes

@leodido leodido leodido approved these changes

@mfdii mfdii Awaiting requested review from mfdii

Assignees

@leodido leodido

@fntlnz fntlnz

Labels
approved area/build dco-signoff: yes kind/bug kind/cleanup kind/failing-test lgtm release-note size/S
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

Build of falcosecurity/falco:stable is broken because of libctf-nobfd0
5 participants
@krisnova @fntlnz @poiana @leodido @ravishankarsrrav