docker minimal images need exact FALCO_VERSION #1069
Merged
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
fntlnz
approved these changes
Mar 2, 2020
|
LGTM label has been added. Git tree hash: ddf60217d189b777ac3439427ba4ec2a710821ed
|
|
This should (ideally) be merged before other PRs @kris-nova PTAL |
mstemm
approved these changes
Mar 3, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@poiana why this is not merged? |
|
Reopening to let poiana handle it, let's see |
|
Oh the problem was that it was queued behind another PR. Now it's IN! Let's party 🎉 |
|
/milestone 0.21.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Leonardo Di Donato leodidonato@gmail.com
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Since
minimaldocker images fetch the falco binary frombinorbin-devrepositories they need to explicitly set theFALCO_VERSIONvariable.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: