build: PROBE_VERSION must use the driver version #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver version was also setup in the wrong cmake file. Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com> Signed-off-by: Lorenzo Fontana <lo@linux.com>
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com> Signed-off-by: Lorenzo Fontana <lo@linux.com>
leodido
approved these changes
Mar 9, 2020
|
LGTM label has been added. Git tree hash: 8a67ba53c4153f5ed18c0906cb951f2f245a7486
|
|
/milestone 0.21.0 |
|
/assign @kris-nova |
|
/cc @kris-nova |
mstemm
approved these changes
Mar 10, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.21.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver version was also setup in the wrong cmake file.
Co-Authored-By: Leonardo Di Donato leodidonato@gmail.com
Signed-off-by: Lorenzo Fontana lo@linux.com
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Which issue(s) this PR fixes:
Passing
-DSYSDIG_VERSIONto cmake was not loading the variable in the inner makefile that we use to download the sinsp, scap and the driver.This was leading to broken builds when such variable was passed.
Moreover,
PROBE_VERSIONmust be set to the same version as the driver, because they are two separate projects with different release lifecycles now that Sysdig and Falco are 100% decoupled from an infrastructure and code point of view.Also we bumped the driver version to benefit from draios/sysdig#1595
Fixes #1073
Special notes for your reviewer:
Does this PR introduce a user-facing change?: