fix(integrations/k8s-using-daemonset): --cri flag correct socket path #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libsinsp cri interface prepends (at runtime) the `HOST_ROOT` prefix. Thus, even if the CRI socket has been mounted on `/host/var/run/containerd/containerd.sock`, the correct `--cri` flag value is `/var/run/containerd/containerd.sock`. Co-authored-by: Lorenzo Fontana <lo@linux.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
leodido
approved these changes
Apr 10, 2020
|
LGTM label has been added. Git tree hash: a5e277a4b82f1d5b48825cee4b7e504a04bc2e8a
|
|
/milestone 0.22.0 |
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
leogr
added a commit
to falcosecurity/charts
that referenced
this pull request
May 21, 2020
See also: - falcosecurity/falco#1140 - https://github.com/falcosecurity/falco/pull/1133/files Co-authored-by: Leonardo Di Donato leodidonato@gmail.com Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
poiana
pushed a commit
to falcosecurity/charts
that referenced
this pull request
May 22, 2020
See also: - falcosecurity/falco#1140 - https://github.com/falcosecurity/falco/pull/1133/files Co-authored-by: Leonardo Di Donato leodidonato@gmail.com Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libsinsp cri interface prepends (at runtime) the
HOST_ROOTprefix.Thus, even if the CRI socket has been mounted on
/host/var/run/containerd/containerd.sock, the correct--criflagvalue is
/var/run/containerd/containerd.sock.Co-authored-by: Lorenzo Fontana lo@linux.com
Signed-off-by: Leonardo Di Donato leodidonato@gmail.com
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area integrations
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: