Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new docker image falcosecurity/falco-no-driver #1205

Merged
merged 4 commits into from
May 14, 2020
Merged

new docker image falcosecurity/falco-no-driver #1205

merged 4 commits into from
May 14, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented May 13, 2020

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:
As per this proposal

See this comment too.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
As discussed privately, the new image (which source code is from the old minimal Dockerfile) is also aliased to falcosecurity/falco:slim-latest to avoid a further breaking change.
Note that the old minimal and the slim had the same purpose, thought a different implementation.

/cc @leodido
/cc @fntlnz

Does this PR introduce a user-facing change?:

new(docker): add `falcosecurity/falco-no-driver` image
update(docker): now `falcosecurity/falco:slim-*` alias to `falcosecurity/falco-no-driver:*`

@poiana poiana requested review from fntlnz and leodido May 13, 2020 16:15
leodido
leodido previously approved these changes May 14, 2020
View reviewed changes
@poiana poiana added the lgtm label May 14, 2020
@poiana
Copy link
Contributor

poiana commented May 14, 2020

LGTM label has been added.

Git tree hash: 8c2c6ed4593785f30860e25e42e69a4351dfa27d

@leogr
Copy link
Member Author

leogr commented May 14, 2020

/milestone 0.23.0

@poiana poiana added this to the 0.23.0 milestone May 14, 2020
leogr added 3 commits May 14, 2020 16:41
@leogr
docs(docker): add falcosecurity/falco-no-driver image
d1a2954 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
new(docker): add falco-no-driver image
8c68b62 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
fix(docker/no-driver): enable time_format_iso_8601 by default
ae774e8 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr force-pushed the new/docker-no-driver branch from a4159a3 to 33d788c Compare May 14, 2020 14:41
@poiana poiana removed the lgtm label May 14, 2020
@leogr
update(docker/falco): rename folder for naminig consistency
199e495 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr force-pushed the new/docker-no-driver branch from 33d788c to 199e495 Compare May 14, 2020 14:46
@poiana poiana removed the approved label May 14, 2020
@leogr
Copy link
Member Author

leogr commented May 14, 2020

Hey @leodido
By 199e495 I have renamed the docker/stable folder to docker/falco as privately discussed. Please double-check it.

@leogr leogr requested a review from leodido May 14, 2020 16:25
@leogr leogr changed the title wip: new docker image falcosecurity/falco-no-driver new docker image falcosecurity/falco-no-driver May 14, 2020
@poiana
Copy link
Contributor

poiana commented May 14, 2020

LGTM label has been added.

Git tree hash: 7065a70d3fb395490d4901aaf7ce955f7a4428e9

@poiana
Copy link
Contributor

poiana commented May 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented May 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit c42cb18 into master May 14, 2020
@poiana poiana deleted the new/docker-no-driver branch May 14, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fntlnz fntlnz fntlnz approved these changes

@leodido leodido leodido approved these changes

Assignees

@leodido leodido

@fntlnz fntlnz

Labels
approved area/build dco-signoff: yes kind/feature lgtm release-note size/L
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@leogr @poiana @leodido @fntlnz