Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(falco-driver-loader): target for ubuntu is ubuntu-generic #1212

Merged
merged 1 commit into from
May 15, 2020

Conversation

reshadp
Copy link
Contributor

@reshadp reshadp commented May 15, 2020

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

The upstream files for the generic Ubuntu kernel are all called ubuntu-generic instead of ubuntu
see: https://dl.bintray.com/falcosecurity/driver/96bd9bc560f67742738eb7255aeb4d03046b8045/

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(scripts): upstream files (prebuilt drivers) for the generic Ubuntu kernel contains "ubuntu-generic"

@poiana
Copy link
Contributor

poiana commented May 15, 2020

Welcome @patuck! It looks like this is your first PR to falcosecurity/falco 🎉

The upstream files for the generic Ubuntu kernel are all called ubuntu-generic
see: https://dl.bintray.com/falcosecurity/driver/96bd9bc560f67742738eb7255aeb4d03046b8045/

Signed-off-by: Reshad Patuck <reshad@patuck.net>
@reshadp
Copy link
Contributor Author

reshadp commented May 15, 2020

@poiana, updated the commit. thanks

Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting it 🤗

@poiana
Copy link
Contributor

poiana commented May 15, 2020

LGTM label has been added.

Git tree hash: 8b32f3b7d4e48562a6532a6562b178e8ebf7c47c

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
LGTM

@poiana poiana merged commit efd0bf1 into falcosecurity:master May 15, 2020
@poiana
Copy link
Contributor

poiana commented May 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants