-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(grpc): Add engine version to version svc #1507
Conversation
Fixes falcosecurity#1269 Add two new fields in the version service for falco's engine version and the checksum of all of the fields it understands. This will require rebuilding/re-releasing all the clients. Signed-off-by: Spencer Krum <nibz@spencerkrum.com>
f81adc2
to
9d6454e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Spencer!
LGTM label has been added. Git tree hash: 6fec5d9bd48950b259109db5a5be801020de5e96
|
/milestone 0.27.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Spencer!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updated the release notes to fit our scheme. |
Add two new fields in the version service for falco's engine version and
the checksum of all of the fields it understands.
This will require rebuilding/re-releasing all the clients.
Signed-off-by: Spencer Krum nibz@spencerkrum.com
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
What this PR does / why we need it:
Adds engine version to version endpoint
Which issue(s) this PR fixes:
Fixes #1269
Special notes for your reviewer:
Tested using the client-go:
Does this PR introduce a user-facing change?: