Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(grpc): Add engine version to version svc #1507

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

nibalizer
Copy link
Contributor

@nibalizer nibalizer commented Dec 11, 2020

Add two new fields in the version service for falco's engine version and
the checksum of all of the fields it understands.

This will require rebuilding/re-releasing all the clients.

Signed-off-by: Spencer Krum nibz@spencerkrum.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Adds engine version to version endpoint

Which issue(s) this PR fixes:

Fixes #1269

Special notes for your reviewer:

Tested using the client-go:

./version_unix_socket
{"version":"0.26.1-114+6443bb7","minor":26,"patch":1,"prerelease":"114","build":"6443bb7","engineVersion":7,"engineFieldsChecksum":"2f324e2e66d4b423f53600e7e0fcf2f0ff72e4a87755c490f2ae8f310aba9386"}

Does this PR introduce a user-facing change?:

new: Added falco engine version to grpc version service

Fixes falcosecurity#1269

Add two new fields in the version service for falco's engine version and
the checksum of all of the fields it understands.

This will require rebuilding/re-releasing all the clients.

Signed-off-by: Spencer Krum <nibz@spencerkrum.com>
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Spencer!

@poiana
Copy link
Contributor

poiana commented Dec 14, 2020

LGTM label has been added.

Git tree hash: 6fec5d9bd48950b259109db5a5be801020de5e96

@leodido
Copy link
Member

leodido commented Dec 14, 2020

/milestone 0.27.0

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Spencer!

@poiana
Copy link
Contributor

poiana commented Dec 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d03a1f4 into falcosecurity:master Dec 15, 2020
@fntlnz
Copy link
Contributor

fntlnz commented Jan 15, 2021

Updated the release notes to fit our scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose the Falco Engine version through the gRPC Version API
5 participants