-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule Update - Adds npm support to pkg mgt processes #1866
Conversation
Welcome @rileydakota! It looks like this is your first PR to falcosecurity/falco 🎉 |
Hi @rileydakota! Thanks for your contribution. Can you sign-off your commit? |
Adds `npm` to `package_mgmt_binaries` for detection of "living off the land" style attacks that utilize NPM pull down additional tooling Signed-off-by: rileydakota <dakotariley2@gmail.com>
/cc @Kaizhe |
/milestone 0.32.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 568d596468083146e758fce93905961628a8c165
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr, rileydakota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was approved in error and generates false positives over 99% of the time.
|
Unless it can be rewritten to exclude npm start it should be backed out |
@rileydakota this is awful. 99% false positives in the real world.
Is the most common log message. While the intention is good it resulted in all of the package management processes being ignored resulting in a net negative. |
potentially could break it into a separate rule and rely on It may also be worth considering if other package managers have this issue. |
Adds
npm
topackage_mgmt_binaries
for detection of "living off the land" style attacks that utilize NPM to pull down additional tooling/librariesWhat type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Adds
npm
to the list ofpackage_management_binaries
. NodeJS is one of the most popular development languages in the world - and thenode
base image comes packaged with npm. Like other package managers - npm installing packages in an already built container is a best practice violation at best, and a potential IoC at worst (attackers could potentially use it to pull down additional tooling/libraries without tripping the existing package management process alerts).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Yes