Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ouput Rules K8s Serviceaccount Created/Deleted #1973

Conversation

darryk10
Copy link
Contributor

This PR just fix the output in the rules K8s Serviceaccount Created/Deleted

Signed-off-by: darryk10 stefano.chierici@sysdig.com
Co-authored-by: AlbertoPellitteri alberto.pellitteri@sysdig.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
This PR just fix the output in the rules K8s Serviceaccount Created/Deleted
Which issue(s) this PR fixes:
the output at the moment is misleading.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(K8s Serviceaccount Created/Deleted): Fixed output for the rules

Signed-off-by: darryk10 <stefano.chierici@sysdig.com>
Co-authored-by: AlbertoPellitteri <alberto.pellitteri@sysdig.com>
@poiana
Copy link
Contributor

poiana commented Apr 15, 2022

LGTM label has been added.

Git tree hash: 3872d1d41328772f2e4503404072c8f84a63e9db

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Apr 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darryk10, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d3383b4 into falcosecurity:master Apr 15, 2022
@darryk10 darryk10 deleted the fix_output_k8s_serviceaccount_created_deleted branch April 15, 2022 08:50
@jasondellaluce
Copy link
Contributor

/milestone 0.32.0

@poiana poiana added this to the 0.32.0 milestone Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants