fix(tests): make run_regression_tests.sh work locally #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/milestone 0.33.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: bb52ced9f6d34dbff13ef8cfa4d89f7018ef0b75
|
Signed-off-by: Luca Guerra <luca@guerra.sh>
LucaGuerra
force-pushed
the
fix/run-tests-locally
branch
from
352e1c9 to
8076c92
Compare
jasondellaluce
approved these changes
Jun 11, 2022
|
LGTM label has been added. Git tree hash: d5567b1e9391f7ce4f3fe1342333c07484b3fb04
|
leogr
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luca Guerra luca@guerra.sh
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area tests
What this PR does / why we need it:
The Falco manual and the README in the test directory tell how to run the Falco test suite locally. I think it's very valuable during development however the instructions are a little outdated I believe since:
test-trace-fileswhich has been removed in PR Cmake speedups #1905It looks like the script assumes to be launched from the trace files directory as all of their paths are relative.
In addition, I don't exactly know why, but it looks like trace files exist both in the Falco repo and in an external storage. Maybe some other contributor or maintainers have more clues about that.
The PR updates the readme file and launches the test from the trace file directory.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: