Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fixed circleCI artifacts publish for arm64. #2051

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jun 9, 2022

Signed-off-by: Federico Di Pierro nierro92@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

leogr
leogr previously approved these changes Jun 9, 2022
@poiana poiana added the lgtm label Jun 9, 2022
@poiana
Copy link
Contributor

poiana commented Jun 9, 2022

LGTM label has been added.

Git tree hash: d9062efdbfa2315e124f308b3235117bc732a018

@leogr
Copy link
Member

leogr commented Jun 9, 2022

N.B. I have temporarily disabled the required status checks in order to fix the CI issue we are having.

jasondellaluce
jasondellaluce previously approved these changes Jun 9, 2022
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@leogr
Copy link
Member

leogr commented Jun 9, 2022

/poiana

@poiana
Copy link
Contributor

poiana commented Jun 9, 2022

@leogr: Poiana stops the drama!

In response to this:

/poiana

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr leogr closed this Jun 9, 2022
@leogr leogr reopened this Jun 9, 2022
@leogr leogr closed this Jun 9, 2022
@leogr leogr reopened this Jun 9, 2022
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP dismissed stale reviews from jasondellaluce and leogr via aafc450 June 9, 2022 08:11
@FedeDP FedeDP force-pushed the fix/arm64_packages branch from 363225a to aafc450 Compare June 9, 2022 08:11
@poiana poiana removed the lgtm label Jun 9, 2022
@poiana poiana requested review from jasondellaluce and leogr June 9, 2022 08:11
@poiana poiana removed the size/S label Jun 9, 2022
@poiana poiana added the size/M label Jun 9, 2022
@poiana poiana added the lgtm label Jun 9, 2022
@poiana
Copy link
Contributor

poiana commented Jun 9, 2022

LGTM label has been added.

Git tree hash: d57a3f8df9e16dfc10ccb9ccf15fd69e481564d4

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 534f66e into falcosecurity:master Jun 9, 2022
@jasondellaluce jasondellaluce added this to the 0.33.0 milestone Jun 9, 2022
@jasondellaluce jasondellaluce modified the milestones: 0.33.0, 0.32.1 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants