-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scripts): fixed falco-driver-loader driver download url. #2057
Conversation
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
/milestone 0.33.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/bark
❤️
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: ccbad47ebc494c05f40cc00b10e28177222e7766
|
Poiana is love, poiana is life ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we will publish the driver with the new directory structure in time :)
@FedeDP we have to update the documentation too 👇
https://falco.org/docs/getting-started/installation/#install-driver
Signed-off-by: Federico Di Pierro nierro92@gmail.com
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is part of a bigger change on how we store drivers on s3 bucket.
Next changes need to be made in test-infra driverkit makefile and will come in the next days.
Does this PR introduce a user-facing change?: