-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): sign arm64 rpm packages. #2069
Conversation
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
8ff152d
to
ef48179
Compare
Despite the change directory statement, the execution of the sign script, and the verification of the signature, wouldn't it make more sense to add the rest to
And on the signing
This way there'd be less duplicity of code but still 2 independent stages. |
Signed-off-by: Federico Di Pierro <nierro92@gmail.com> Co-authored-by: Vicente J. Jiménez Miras <vjjmiras@gmail.com>
@vjjmiras should be ok now, right? |
LGTM |
/hold |
Signed-off-by: Federico Di Pierro <nierro92@gmail.com> Co-authored-by: Vicente J. Jiménez Miras <vjjmiras@gmail.com>
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/milestone 0.32.1
/approve
LGTM label has been added. Git tree hash: 82dd4c78c548cf74ab56456acf675ffaa481db05
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We forgot to change the location of the ~/sign file when creating it. |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2064
Special notes for your reviewer:
Does this PR introduce a user-facing change?: