Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fix sign script - avoid interpreting '{*}$argv' too soon #2075

Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix(ci): fix sign script - avoid interpreting '{*}$argv' too soon #2075

merged 1 commit into from
Jun 20, 2022

Conversation

vjjmiras
Copy link
Contributor

@vjjmiras vjjmiras commented Jun 20, 2022 •
edited by jasondellaluce
Loading

Signed-off-by: Vicente J. Jiménez Miras vjjmiras@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@vjjmiras
fix(ci): fix sign script - avoid interpreting {*}$argv
4737a5c 
Signed-off-by: Vicente J. Jiménez Miras <vjjmiras@gmail.com>
@poiana poiana requested review from jonahjon and mfdii June 20, 2022 09:50
leogr
leogr approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana poiana added the lgtm label Jun 20, 2022
@poiana
Copy link
Contributor

poiana commented Jun 20, 2022

LGTM label has been added.

Git tree hash: 1e690aeba0c03c8e18e041ef972f88ebf2e7f460

jasondellaluce
jasondellaluce approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, vjjmiras

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Jun 20, 2022

@jasondellaluce Note that we are missing the release notes!

@poiana poiana merged commit 5d10e54 into falcosecurity:master Jun 20, 2022
@jasondellaluce
Copy link
Contributor

/milestone 0.32.1

@poiana poiana added this to the 0.32.1 milestone Jun 27, 2022
@vjjmiras vjjmiras deleted the fix-sign-script-2 branch January 26, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@leogr leogr leogr approved these changes

@jonahjon jonahjon Awaiting requested review from jonahjon

@mfdii mfdii Awaiting requested review from mfdii

Assignees

@leogr leogr

@jasondellaluce jasondellaluce

Labels
approved area/build dco-signoff: yes kind/bug lgtm release-note-none size/XS
Projects
None yet
Milestone
0.32.1
Development

Successfully merging this pull request may close these issues.
5 participants
@vjjmiras @poiana @FedeDP @jasondellaluce @leogr