Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adapt regressions after dup change and version bump #2092

Merged
merged 3 commits into from
Jun 23, 2022
Merged

fix: adapt regressions after dup change and version bump #2092

merged 3 commits into from
Jun 23, 2022

Conversation

leogr
Copy link
Member

@leogr leogr commented Jun 23, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

Fixes #

Special notes for your reviewer:

/milestone 0.32.1

Does this PR introduce a user-facing change?:

rule(Redirect STDOUT/STDIN to Network Connection in Container): changed priority to NOTICE

leogr added 2 commits June 23, 2022 15:10
@leogr
update(rules): lower priority to noisy rule (after the dup improvement)
592232d 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
fix(test): correct "incompat_plugin_api" expectation
528c419 
See falcosecurity/libs#389

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@poiana poiana added this to the 0.32.1 milestone Jun 23, 2022
@poiana poiana requested review from FedeDP and fntlnz June 23, 2022 13:18
@jasondellaluce @LucaGuerra
fix(test): update expected test result for docker-compose scap file
6a29fae 
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: Luca Guerra <luca@guerra.sh>
@jasondellaluce jasondellaluce force-pushed the fix/regressions-after-dup-change branch from 359a8e3 to 6a29fae Compare June 23, 2022 15:26
FedeDP
FedeDP approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jun 23, 2022
jasondellaluce
jasondellaluce approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit 555bf99 into master Jun 23, 2022
@poiana poiana deleted the fix/regressions-after-dup-change branch June 23, 2022 16:12
@poiana
Copy link
Contributor

poiana commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@FedeDP FedeDP FedeDP approved these changes

@fntlnz fntlnz Awaiting requested review from fntlnz

Assignees

@FedeDP FedeDP

@jasondellaluce jasondellaluce

Labels
approved area/rules area/tests dco-signoff: yes kind/bug kind/failing-test kind/rule-update lgtm release-note size/S
Projects
None yet
Milestone
0.32.1
Development

Successfully merging this pull request may close these issues.
4 participants
@leogr @poiana @FedeDP @jasondellaluce