update(userspace/falco): support libs logging #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasondellaluce
commented
Jun 23, 2022
15 tasks
jasondellaluce
force-pushed
the
new/sinsp-logging
branch
from
26b4ccc to
b0dcb37
Compare
|
/milestone 0.33.0 |
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
jasondellaluce
force-pushed
the
new/sinsp-logging
branch
from
b0dcb37 to
d5e1415
Compare
jasondellaluce
changed the title
jasondellaluce
changed the title
jasondellaluce
force-pushed
the
new/sinsp-logging
branch
from
d5e1415 to
df1e676
Compare
…on (default to false) Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
jasondellaluce
force-pushed
the
new/sinsp-logging
branch
from
df1e676 to
7c80135
Compare
|
LGTM label has been added. Git tree hash: 87b685a135a42b162947e1facfa8b4668a7dfa40
|
LucaGuerra
reviewed
Jun 30, 2022
|
/remove-milestone 0.33.0 |
|
I think this will be very helpful when debugging libs changes. Thank you! ❤️ |
Co-authored-by: Luca Guerra <luca@guerra.sh> Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
|
LGTM label has been added. Git tree hash: cc6994d91194a488c3d08cdd188e8d72db05a986
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR adds support to logs coming from libsinsp, which are now piped into the Falco logger. By default this is disabled in order to avoid breaking changes in the UX as for the messages printed to stderr. A new option
libs_loggerhas been added in thefalco.yamlconfiguration.Which issue(s) this PR fixes:
Fixes #2068
Special notes for your reviewer:
Does this PR introduce a user-facing change?: