refactor(userspace/engine): drop macro source field in rules and rule loader #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oader Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
15 tasks
leogr
approved these changes
Jun 27, 2022
|
LGTM label has been added. Git tree hash: 1d651227cf2761b336b313008df08e708615ed69
|
|
/milestone 0.32.1 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
/area tests
What this PR does / why we need it:
Since being ported from Lua to C++, the Falco rule loader supported defining a
sourcefield in both rules and macros, meant to define compatibility with a specific event source. However, having source definitions in macros is not meaningful, and also the current implementation does not enforce any check during ruleset compilation (it just reads the value from the YAML). On the opposite, I think not defining a source for macros is the way to go. This would enable ruleset developers to create cross-source macros (for example, thejsonplugin can be used to build macros that are valid for all the json-based event sources such ascloudtrailandk8s_audit). As such, this PR drops the notion of macro-specific source and its related regression tests.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: